Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Remove reduced weight for regional species from egg pulls #4882

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Nov 16, 2024

What are the changes the user will see?

Regional forms will no longer appear less often from eggs.

Why am I making these changes?

Requested by balance.
damo edit: (to go with #4883)

What are the changes from a developer perspective?

Removed the "regional" check from egg creation.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • [ ] Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

@DayKev DayKev added the Balance Team Specifically a balance team change label Nov 16, 2024
@DayKev DayKev requested a review from a team as a code owner November 16, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants